Support __cuda_array_interface__ types without len()
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
improvement
rjzamora
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Thanks @pentschev !
I'm eager to get this in, so I don't want to make you jump through any unnecessary hoops. With that said, I have one suggestion: Can we add a comment explaining why we are adding this patch? Ideally, the comment would explain what a "long-term" fix would look like (do we know what that looks like?)
Actually, maybe we'll be better off implementing |
3 tasks
|
Superseded by rapidsai/cudf#18133 , closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
__cuda_array_interface__types that do not implement the__len__method. Thedistributed.utils.nbytesfunction that we currently use relies on determining the size of object using either the__len__methods implemented by the type or thenbytesattribute, which are not required by types that implement__cuda_array_interface__, such aspylibcudf.gpumemoryview. This change attempts to use the existingdistributed.utils.nbytesfunction, and if that does not succeed then proceeds to calculate the size based on the attributes of__cuda_array_interface__. Note that strides are not currently implemented.